atom icon indicating copy to clipboard operation
atom copied to clipboard

Published 20 hours ago • verified publisher icon lardemua

Misuse of xacro name

Open manuelgitgomes opened this issue 1 year ago • 4 comments

Hello @miguelriemoliveira.

I think we have misused the "xacro" name a lot. After calibration we generate an URDF that does not use any xacro features, such as macros or properties.

I think it would be less confusing to call it URDF.

manuelgitgomes avatar Dec 06 '23 10:12 manuelgitgomes

Right. I agree, we often are reffering to the URDF.

miguelriemoliveira avatar Dec 06 '23 19:12 miguelriemoliveira

I agree, but what should we do? Is there anything to do on this issue or should we close?

miguelriemoliveira avatar Dec 06 '23 23:12 miguelriemoliveira

I agree, but what should we do? Is there anything to do on this issue or should we close?

We should change the generated URDF to be only .urdf and not .urdf.xacro (the inital_estimate and the optimized one). Some prints also state xacro instead of urdf.

manuelgitgomes avatar Dec 07 '23 10:12 manuelgitgomes

Right. Makes sense. Can you do it?

miguelriemoliveira avatar Dec 07 '23 13:12 miguelriemoliveira