laravel.io icon indicating copy to clipboard operation
laravel.io copied to clipboard

add report spam functionality

Open sawirricardo opened this issue 1 year ago • 5 comments

Hi @driesvints , did you mean resend in again something like this? https://github.com/laravelio/laravel.io/pull/878#issuecomment-1178723392

sawirricardo avatar Jul 08 '22 15:07 sawirricardo

@sawirricardo can you rebase this one?

driesvints avatar Jul 27 '22 13:07 driesvints

@driesvints hm, do you mind to guide me? I think I have no clue about rebasing as before the rebasing seemed failed here https://github.com/laravelio/laravel.io/pull/878

sawirricardo avatar Jul 28 '22 00:07 sawirricardo

@sawirricardo if rebasing is too hard you can simply also merge main into this branch.

driesvints avatar Jul 28 '22 06:07 driesvints

Here's a tutorial about rebasing btw: https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase

driesvints avatar Jul 28 '22 06:07 driesvints

@driesvints hopefully, I rebased it right, let me know 👍

sawirricardo avatar Jul 28 '22 16:07 sawirricardo

Just two small remarks. Sorry, I've been struggling to find time to review open PR's.

driesvints avatar Aug 17 '22 14:08 driesvints

Just two small remarks. Sorry, I've been struggling to find time to review open PR's.

No problem @driesvints , it's me who should be thankful that you're willing to review this PR 🙏🏻

sawirricardo avatar Aug 18 '22 02:08 sawirricardo

I finally managed to work on this a little bit yesterday. I still need to look into some stuff (one failing tests and reporting replies) but then I think this is gtg. I revised some terminology and concepts like renaming the SpamAble interface to Spam as that's what it's actually is. And the spam table should actually be spam_reports.

driesvints avatar Sep 22 '22 08:09 driesvints

Heya. I had to sent this in through a different PR because I couldn't push here anymore. Thanks a lot @sawirricardo!

driesvints avatar Sep 28 '22 12:09 driesvints

thanks @driesvints !

sawirricardo avatar Sep 28 '22 13:09 sawirricardo