valet icon indicating copy to clipboard operation
valet copied to clipboard

Passing arguments to Ngrok broken in v.4.8.0

Open kiritokatklian opened this issue 1 year ago • 2 comments

Description

v4.8.0 breaks passing arguments like --domain with the valet share command. Only tested with Ngrok. For now I've downgraded back to v4.7.1, since it works in this version

Steps To Reproduce

$ valet share-tool ngrok
$ valet share --domain=custom.domain

Diagnosis

N/A

kiritokatklian avatar Sep 11 '24 23:09 kiritokatklian

Could be related to #1467 /cc @rcknr

drbyte avatar Sep 15 '24 06:09 drbyte

It seems like this line has to have != instead of ==.

skauk avatar Sep 15 '24 17:09 skauk