framework icon indicating copy to clipboard operation
framework copied to clipboard
Published 3 months ago • verified publisher icon laravel

[10.x] Use 'none' as key when Configuring the MultiSearch and MultiSelectPrompt prompts

Open weitzman opened this issue 2 years ago • 0 comments

Without this change, the Symfony Console ChoiceQuestion gives an InvalidArgumentException. A value of "" is invalid and that is what None is using without this PR.

I found this when adding Prompts to Drush, but I think it applies to Laravel Framework as well. Here is our test failure that showed this bug https://app.circleci.com/pipelines/github/drush-ops/drush/6234/workflows/d0ec5398-d4dd-4b85-8bf8-5a7d31c8c377/jobs/36497/tests#failed-test-0

I looked into adding a test for this but I'm new here and could use guidance. The bug wont show up if we mock the ChoiceQuestion, as existing tests do.

In case anyone is unclear - the bug is in this repo, not in the Prompts repo.

weitzman avatar Dec 13 '23 13:12 weitzman