twilio
twilio copied to clipboard
Enable overriding the Twilio message source
Hey there. This PR adds a new overridable getMessage()
method to TwilioChannel
. This makes it a lot easier to use a notification method named something other than toTwilio
when subclassing TwilioChannel
.
Background: I need to send both SMS and voice messages from a single notification (similar to #97). This PR would make it a lot easier for me to create e.g. a TwilioSmsChannel
class that calls ->toTwilioSms()
on the notification, and a TwilioVoiceChannel
class that calls ->toTwilioVoice()
. That way I'll be able to use both TwilioSmsChannel
and TwilioVoiceChannel
in the same notification class.
I wanted to keep this PR simple, but let me know if you want me to add these TwilioSmsChannel
/TwilioVoiceChannel
classes here as well.
Thanks!!
Hey @atymic! Just a friendly ping for this one 😃 Would love to get this merged if possible!
Would like this to get merge, but copying the class and renaming the class seem work ok.