laravel icon indicating copy to clipboard operation
laravel copied to clipboard

Review whether polymorphic relation interface is required

Open lindyhopchris opened this issue 4 years ago • 2 comments

At the moment we have a Contracts\Schema\PolymorphicRelation interface, with a inverseTypes() method on it.

This is actually redundant as we have added the allInverse() method to the Relation contract. We can probably just remove the polymorphic relation interface and add isPolymorph() and isNotPolymorph() helper methods to the relation interface.

So creating this issue as a reminder to review whether we do actually need to the seperate interface as it would be good to remove it during the beta series if it is no longer required.

lindyhopchris avatar Apr 01 '21 13:04 lindyhopchris

See #59 as these two issues should be dealt with together.

lindyhopchris avatar Apr 20 '21 12:04 lindyhopchris

Removed from milestone as deferring this to a subsequent beta release.

lindyhopchris avatar Apr 20 '21 12:04 lindyhopchris