tall icon indicating copy to clipboard operation
tall copied to clipboard

Extract styles/components from reused classes?

Open imliam opened this issue 4 years ago • 1 comments

I figured I'd raise this as a discussion point to see what people think so we can come to a consensus before raising anything.

Right now we've got a handful of CSS classes we re-use all over the auth views, in particular for things like <button> styles. In most real applications, I'd personally see this as something I need to commonly reuse, and I'd extract it to either a Blade component <x-button> or CSS class .button

That said, the buttons we have so far are not typical buttons you'd find in an app - there's no primary/secondary/danger/etc. styles and it's not guaranteed people will use these styles again as the button is specifically styled for the auth pages.

Thoughts?

imliam avatar May 09 '20 10:05 imliam

Hi @imliam. I've done essentially this on my latest build which started with this TALL Preset. Would you like me to submit a PR?

I've extracted components for x-button, x-input, x-label and x-input.checkbox.

jeffgreco13 avatar Nov 24 '21 23:11 jeffgreco13