Commander icon indicating copy to clipboard operation
Commander copied to clipboard

Axing persistent decorators

Open aarongustafson opened this issue 11 years ago • 8 comments

This pull request fixes #22.

aarongustafson avatar Aug 13 '14 19:08 aarongustafson

Hmm - I'm not sure I like the idea of 'undecorate'. I'll see if I can make it reset every time.

JeffreyWay avatar Aug 15 '14 17:08 JeffreyWay

Yeah, I had a hard time coming up with a name :-)

Hmm - I'm not sure I like the idea of 'undecorate'. I'll see if I can make it reset every time.

— Reply to this email directly or view it on GitHub (https://github.com/laracasts/Commander/pull/27#issuecomment-52336429).

aarongustafson avatar Aug 15 '14 19:08 aarongustafson

Hey Jeff,

Do you have any tips on how to run multiple commands with their own decorators in one controller action? It does not seem to be possible. The second command hits the decorators of the first. Please let us know or consider this pull request please.

dimamarkus avatar Oct 27 '14 04:10 dimamarkus

@JeffreyWay Would you be okay with clearDecorators() instead of undecorate()?

@aarongustafson Can you update the pull request to fix the merge conflicts (looks like just a comment has changed)? Also, you don't have to do if (count($decorators)) you can just do if ($decorators).

MitchellMcKenna avatar Nov 07 '14 01:11 MitchellMcKenna

I really need this fix? when will it be merged?

ronnievisser avatar Nov 14 '14 21:11 ronnievisser

Related to this issue I found another but. when for example foreaching a collection en in that foreach you have a command executed with a decorated the command itself get's multiplied. so first 1 command, second 2 commands, third item 3 commands, etc etc..

ronnievisser avatar Nov 14 '14 21:11 ronnievisser

+1. I just go into the same problem, will this be fixed?

jojovem avatar Dec 04 '14 16:12 jojovem

I tweaked the method name and the conditional.

aarongustafson avatar Dec 07 '14 16:12 aarongustafson