BotFlow icon indicating copy to clipboard operation
BotFlow copied to clipboard

Disable delete button when intent has a single text field

Open rodmaia opened this issue 4 years ago • 6 comments

When an intent has a single text field, the delete button of that text field should be disabled as you cannot leave an intent with zero questions. The delete button should be reenabled once you add more text fields.

Tasks

  • [x] Steps to complete this task
  • [x] Steps to complete this task

Acceptance criteria

  • [x] Delete button is disabled when there is a single text field
  • [x] Delete button is enabled when there are two or more text fields

rodmaia avatar Feb 23 '21 19:02 rodmaia

Reviewing this issue based on #153;

Miguel-Alves avatar Feb 25 '21 15:02 Miguel-Alves

This issue was maintained following the procedures of #153;

Although it was maintained, it asks for a redundant work and validation, since there is already a validation that doesn't allow the user to delete the last or only question, even if the button is enabled.

Miguel-Alves avatar Mar 02 '21 14:03 Miguel-Alves

Solved this issue as described in #162

Miguel-Alves avatar Mar 02 '21 14:03 Miguel-Alves

Although it was maintained, it asks for a redundant work and validation, since there is already a validation that doesn't allow the user to delete the last or only question, even if the button is enabled.

It's not redundant because we are exposing the actual behavior in a way people can understand, following the usability principle of Visibility of the System 😉

rodmaia avatar Mar 02 '21 15:03 rodmaia

Got it! Thanks by the answer. It makes total sense. The validation was added, and a PR to solve this issue is open.

Miguel-Alves avatar May 12 '21 23:05 Miguel-Alves

I tested it! Looks good on my side.

rodmaia avatar May 19 '21 19:05 rodmaia