BotFlow icon indicating copy to clipboard operation
BotFlow copied to clipboard

Disable delete button when utter has a single balloon

Open rodmaia opened this issue 4 years ago • 6 comments

When an utter has a single text balloon, the delete button of that balloon should be disabled as you cannot leave an utter with zero balloons. The delete button should be reenabled once you add more balloons.

Tasks

  • [x] Steps to complete this task
  • [x] Steps to complete this task

Acceptance criteria

  • [x] Delete button is disabled when there is a single balloon
  • [x] Delete button is enabled when there are two or more balloons

rodmaia avatar Feb 23 '21 19:02 rodmaia

Reviewing this issue based on #153;

Miguel-Alves avatar Feb 25 '21 15:02 Miguel-Alves

This issue is very similar to #151 . And, as it happened to it's "sister", happens here either. This work is kind of redundant as already exists a validation that does not allow the user to delete the last content. But, following the procedures of #153 , this issue is maintained;

Miguel-Alves avatar Mar 02 '21 14:03 Miguel-Alves

Solved this issue adding another validation to the button when editing utters, as described in #163 ; Then, this issue was moved to "Awaiting Review"

Miguel-Alves avatar Mar 02 '21 14:03 Miguel-Alves

This work is kind of redundant as already exists a validation that does not allow the user to delete the last content.

See https://github.com/lappis-unb/BotFlow/issues/151#issuecomment-788993997

rodmaia avatar Mar 02 '21 15:03 rodmaia

Checked it and now I understand these needs and procedures. Anyway, I added the validation that solves this issue and a PR solving it is open

Miguel-Alves avatar May 12 '21 23:05 Miguel-Alves

I tested it! Looks good on my end.

rodmaia avatar May 19 '21 19:05 rodmaia