floem icon indicating copy to clipboard operation
floem copied to clipboard

Convert examples/* to proper cargo-manifest structure.

Open maaku opened this issue 1 year ago • 2 comments

I hope this is well-received as I didn't ask before authoring. While evaluating floem for use in my own app, I started with the examples and got frustrated that I couldn't build them / run them / doc them from the workspace directory with the standard cargo run --example <name> command, or to build/test them all with e.g. cargo build --examples. This is because they are created as workspace crates, not as proper cargo examples.

This PR converts them all to standard cargo manifest examples.

maaku avatar Jul 10 '24 07:07 maaku

You should run them as cargo run -p <name> also I'd prefer if they were kept as they are now, since it's not an uncommon way to store/run examples

panekj avatar Jul 10 '24 07:07 panekj

Whether or not the structural changes will be merged, I think the added doc comments are helpful.

timsueberkrueb avatar Aug 03 '24 10:08 timsueberkrueb

I'm going to go ahead and close this for now as I think the current structure is preferred but thanks for taking the time to work on improving things!

jrmoulton avatar Jan 26 '25 22:01 jrmoulton