floem icon indicating copy to clipboard operation
floem copied to clipboard

deps: kurbo is used via peniko.

Open waywardmonkeys opened this issue 1 year ago • 5 comments

Since all usages of kurbo are via peniko, the direct dependency on kurbo is not needed. This makes it easier to keep versions in sync.

The re-export of kurbo was happening directly so it could have been out of sync with an updated peniko, so re-export the version from peniko instead.

waywardmonkeys avatar May 23 '24 06:05 waywardmonkeys

(Noticed this when looking at your branch that replicates the vello bug.)

waywardmonkeys avatar May 23 '24 06:05 waywardmonkeys

peniko 0.1.0 doesn't give the options to turn on serde feature on kurbo. That's why we had to use kurbo directly.

dzhou121 avatar May 24 '24 16:05 dzhou121

I see.

The current main branch of peniko has serde support now, so would it be useful if we did a release of that?

waywardmonkeys avatar May 24 '24 16:05 waywardmonkeys

I see.

The current main branch of peniko has serde support now, so would it be useful if we did a release of that?

Yes!

dzhou121 avatar May 24 '24 16:05 dzhou121

@dzhou121 I have brought it up on the Zulip: https://xi.zulipchat.com/#narrow/stream/260979-kurbo/topic/New.20release.20of.20peniko.3F

waywardmonkeys avatar May 24 '24 16:05 waywardmonkeys

Okay, peniko version 0.1.1 is published now and this PR is now updated to use it and enable the serde feature.

waywardmonkeys avatar May 27 '24 16:05 waywardmonkeys

Thanks!

dzhou121 avatar May 27 '24 20:05 dzhou121