Allon Moritz comments

Results 343 comments of


                                            Allon Moritz

[5.2] Remove get()/set() calls to table classes

Thanks!

[cypress] Fail in case of SMTP problems with a clear message

Thanks for the pr' it is looking good. The only issue I have is that the SMTP server is a hard requirement for the test suite. So if it is...

[cypress] Fail in case of SMTP problems with a clear message

I still don't think that we should add such kind of error messages as the tests should expect a working environment. When they fail, that because there is a bug...

[cypress] Fail in case of SMTP problems with a clear message

> there is already a test 'can send a test mail' that fails if SMTP connection fails This test tests settings in the configuration form and is not here to...

[4.4] Added an api test for administrator menu items.

@rajputanuj31 can you have a look on the tests. The admin menu item fails all the time. Thanks...

[4.4] Added an api test for administrator menu items.

@rajputanuj31 can you have a look on the tests. The admin menu item fails all the time. Thanks...

[4.4] Added an api test for administrator menu items.

Thanks!

[5.3] system test for multi-factor authentication plugins (passkey)

Thanks!

Use QueryMonitorInterface instead of hard-coded DebugMonitor class

Adding new methods to an interface breaks per se the classes implementing the interface ;-)

Use QueryMonitorInterface instead of hard-coded DebugMonitor class

Can you prepare the pr in a way how it would work then for you, so we can discus this in maintainers meeting. There should be reason why the class...