ceiba-dl icon indicating copy to clipboard operation
ceiba-dl copied to clipboard

add filename validator before saving files

Open b04505009 opened this issue 4 years ago • 1 comments

Some characters like colon and quotation mark are not allowed to be in a file's path. I recommend to use library like pathvalidate to validate those name before creating files.

I opened a PR #16

b04505009 avatar Dec 06 '20 17:12 b04505009

Some characters like colon and quotation mark are not allowed to be in a file's path.

這個專案最初是在 Linux 上開發的,後來也在 FreeBSD 跑過,但沒什麼測試過 Windows。我承認我當時幾乎沒有考慮檔名可能有特殊字元的問題,因此只處理了我自己測試有遇到的兩個狀況:檔名不能有 / 和檔名過長。

I recommend to use library like pathvalidate to validate those name before creating files.

我其實比較希望盡可能保留原始檔名,也就是類似目前處理檔名過長的方式:如果可以成功開啟檔案,就使用原本的檔名;如果因檔名有特殊字元而無法開啟檔案,則將特殊字元替換成 _ 或其他安全字元再重試。不知道你覺得這樣如何?

lantw44 avatar Jan 31 '22 18:01 lantw44