resque-retry
resque-retry copied to clipboard
Retry page displays delayed jobs
When I open the retry page on resque-web, I can see 67 pages of "retry" jobs. But these aren't actually retry jobs, they're the same delayed jobs I see on the delayed page.
Why not display only the retry jobs there? (possibly the ones starting with "resque-retry")
We use delayed jobs to implement retry, but yes, I think your right normal delayed jobs will also be included in the list.
You could do this by checking retry_attempts_for_job
, if the count does not exist, its not a retry job so can be ignored.
We'd very much appreciate a pull request, are you game @juanibiapina ? :)
@jzaleski This looks very possible to me, do you know of any reason we shouldn't ignore jobs that don't have a retry count?
I would like to, but I unfortunately I don't have the time right now.
Looking at the code it seems the change is not trivial (for me) because jobs are grouped by timestamp.
I don't know exactly what this grouping by timestamp achieves, so I'm not comfortable making the change.
A simpler thing would probably be to remove this timestamp logic and only list jobs, but that would change the pagination logic as well. No idea how to proceed.