scico icon indicating copy to clipboard operation
scico copied to clipboard

Scientific Computational Imaging COde

Results 23 scico issues
Sort by recently updated
recently updated
newest added

Many LinOps have tests for scalar multiplication, i.e., that a * (H @ x) = (a * H) @ x. Right now, this involves code duplication, e.g., https://github.com/lanl/scico/blob/1a66887a03ad4cca5dfa58dfa86386f1536926ba/scico/test/linop/test_circconv.py#L74-L87 versus https://github.com/lanl/scico/blob/1a66887a03ad4cca5dfa58dfa86386f1536926ba/scico/test/linop/test_diag.py#L146-L158...

tests

The mechanism supporting math operations involving `LinearOperator` objects (specifically scalar multiplication and addition and subtraction of two `LinearOperator` objects) should be revisited to determine whether it can be simplified. Specific...

discussion required
improvement

Running the training example scripts with the most recent version of `orbax-checkpoint` results in the following warning ``` WARNING:absl:Configured `CheckpointManager` using deprecated legacy API. Please follow the instructions at https://orbax.readthedocs.io/en/latest/api_refactor.html...

improvement

The comment on this line in `scico.solver.minimize` https://github.com/lanl/scico/blob/4eb21c103b5ec135f7a5a05f933cb0e58b7e64af/scico/solver.py#L216 is incorrect. This should be edited, and it should be confirmed that the functions does work for `BlockArray` input. It's not clear...

bug
discussion required

The scico style guide pages calls for single backtick markup for names of entities such as variables, functions, etc., and does not specify the markup to be used for brief...

documentation
discussion required

Proposed `input_shape` and `output_shape` policy: * All instantiated `Operator`s must have `input_shape` and `output_shape` properties * For an `Operator` `H`, `H(x)` should throw an error if `x` is not `input_shape`...

documentation

A coherent policy for the use of `jax.jit` needs to be formulated and implemented. At present, its usage seems somewhat arbitrary and inconsistent; for example: 1. `Operator` defaults to `jit=False`...

discussion required
improvement

Revisit which functions should be exposed to the user in `scico.flax.train` and which should be explicitly imported from submodules.

documentation
developer

Support has already been added for (DFT) diagonalizable operators, but block diagonalizable operators, and explicit matrix operators, as discussed in the solver design document, have yet to be implemented. We...

enhancement

This issue is related to both typing and explicit array conversion and creation (the latter form being closely related to the subject of #93). At the moment we have a...

discussion required
improvement