PowerModelsDistribution.jl icon indicating copy to clipboard operation
PowerModelsDistribution.jl copied to clipboard

FIX: `parse_file` in `.dss` files with character UTF-8 0x09 (Tabulation)

Open felipemarkson opened this issue 2 years ago • 1 comments

This PR Closes #394. and it is not a breaking change.

Changes

felipemarkson avatar Aug 16 '22 15:08 felipemarkson

Codecov Report

Merging #395 (b6ca4f7) into main (28995a1) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #395      +/-   ##
==========================================
+ Coverage   69.58%   69.60%   +0.01%     
==========================================
  Files          59       59              
  Lines       14607    14607              
==========================================
+ Hits        10165    10167       +2     
+ Misses       4442     4440       -2     
Impacted Files Coverage Δ
src/io/dss/dss_parse.jl 93.10% <100.00%> (ø)
src/io/utils.jl 82.50% <0.00%> (+0.38%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 16 '22 17:08 codecov[bot]

I don't have a MacOs to test why the tests didn't pass :/

felipemarkson avatar Aug 18 '22 13:08 felipemarkson

The problem with the unit test should be fixed, could you merge in the latest main branch to trigger the tests to run again?

pseudocubic avatar Aug 23 '22 15:08 pseudocubic

Thanks for the contribution!

pseudocubic avatar Aug 24 '22 15:08 pseudocubic