PowerModels.jl icon indicating copy to clipboard operation
PowerModels.jl copied to clipboard

Remove epigraph formulation of quadratic objectives for ConicModel

Open odow opened this issue 6 months ago • 2 comments

Closes https://github.com/lanl-ansi/PowerModels.jl/issues/55

We might need to test this on a much larger problem, since there are some test differences. I'll comment in-line on some things.

odow avatar May 01 '25 03:05 odow

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.73%. Comparing base (685fbb2) to head (b727e5d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #969      +/-   ##
==========================================
+ Coverage   93.71%   93.73%   +0.02%     
==========================================
  Files          43       43              
  Lines        9635     9602      -33     
==========================================
- Hits         9029     9000      -29     
+ Misses        606      602       -4     
Files with missing lines Coverage Δ
src/core/objective.jl 96.37% <ø> (+1.63%) :arrow_up:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 685fbb2...b727e5d. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 01 '25 03:05 codecov[bot]

I am thinking it is best to put this in the next breaking release, in an abundance of caution.

ccoffrin avatar May 04 '25 02:05 ccoffrin