PowerModels.jl icon indicating copy to clipboard operation
PowerModels.jl copied to clipboard

current limits vs apparent power limits

Open frederikgeth opened this issue 6 years ago • 4 comments

The apparent power limit functions are separate for to and from side:

  • constraint_thermal_limit_from
  • constraint_thermal_limit_to

Conversely, for the current magnitude, the limits is only enforced on the from side through constraint_current_limit

I'm in favor of splitting constraint_current_limit into constraint_current_limit_to and constraint_current_limit_from. What are your thoughts?

frederikgeth avatar Nov 12 '19 04:11 frederikgeth

Agreed, PR is welcome, but I would recomend that we start a pms-v14 branch for breaking features (like this one). Note, you have write access on this repo so you can make feature branches directly.

ccoffrin avatar Nov 12 '19 04:11 ccoffrin

Great, I'll get on this soon (likely after #622).

frederikgeth avatar Nov 12 '19 05:11 frederikgeth

I had the same idea recently. I would also appreciate this feature! Let me know if I can help.

friederikemeier avatar Oct 20 '20 09:10 friederikemeier

A PR with the change would surely be welcome but this will need to be added to the next breaking release (v0.18 right now). I may be able to get to it in the next couple of weeks.

ccoffrin avatar Oct 20 '20 14:10 ccoffrin

Congrats on closing this issue. I tried to fix it in 2020 but didn't succeed and then moved on with my research in other directions... However, it feels like closure to me, too! Distribution grid modelers will thank you!

friederikemeier avatar Jan 05 '24 09:01 friederikemeier