GraphicalModelLearning.jl icon indicating copy to clipboard operation
GraphicalModelLearning.jl copied to clipboard

Added ferromagnetic models and glauber sampling functions

Open forrestsheldon opened this issue 6 years ago • 4 comments

forrestsheldon avatar Jul 18 '19 23:07 forrestsheldon

Codecov Report

Merging #28 into master will decrease coverage by 13.35%. The diff coverage is 11.65%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #28       +/-   ##
========================================
- Coverage   64.35%   51%   -13.36%     
========================================
  Files           3     3               
  Lines         317   400       +83     
========================================
  Hits          204   204               
- Misses        113   196       +83
Impacted Files Coverage Δ
src/models.jl 30.6% <11.53%> (-15.31%) :arrow_down:
src/sampling.jl 64.38% <12%> (-27.78%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c27fed...1fa8d9b. Read the comment docs.

codecov[bot] avatar Jul 24 '19 04:07 codecov[bot]

Codecov Report

Merging #28 into master will decrease coverage by 13.35%. The diff coverage is 11.65%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #28       +/-   ##
========================================
- Coverage   64.35%   51%   -13.36%     
========================================
  Files           3     3               
  Lines         317   400       +83     
========================================
  Hits          204   204               
- Misses        113   196       +83
Impacted Files Coverage Δ
src/models.jl 30.6% <11.53%> (-15.31%) :arrow_down:
src/sampling.jl 64.38% <12%> (-27.78%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c27fed...1fa8d9b. Read the comment docs.

codecov[bot] avatar Jul 24 '19 04:07 codecov[bot]

Codecov Report

Merging #28 (677effa) into master (ab1ca2a) will decrease coverage by 42.76%. The diff coverage is 2.92%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #28       +/-   ##
===========================================
- Coverage   62.80%   20.03%   -42.77%     
===========================================
  Files           3        3               
  Lines         328     1043      +715     
===========================================
+ Hits          206      209        +3     
- Misses        122      834      +712     
Impacted Files Coverage Δ
src/GraphicalModelLearning.jl 16.08% <0.20%> (-52.63%) :arrow_down:
src/models.jl 25.22% <7.62%> (-19.31%) :arrow_down:
src/sampling.jl 26.94% <8.05%> (-63.63%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ab1ca2a...677effa. Read the comment docs.

codecov[bot] avatar Jul 24 '19 04:07 codecov[bot]

In terms of correctness and style this is good to go. The best practice would be to also add a test so that these features don't break in future versions, but this can wait if this code is still in flux. I'll leave that determination to you. Merge this into master when you are ready.

ccoffrin avatar Jul 24 '19 14:07 ccoffrin