languagetool icon indicating copy to clipboard operation
languagetool copied to clipboard

[pt] rules with many temp_disables

Open susanaboatto opened this issue 2 years ago • 12 comments

  • [x] REPEATED_WORDS_3X: removed from grammar
  • [x] GENERAL_NUMBER_FORMAT: disabled
  • [x] INTERJECTIONS_PUNTUATION
  • [x] UPPERCASE_AFTER_COMMA
  • [x] FAZER_EFETUAR_REALIZAR_CONDUZIR_CONCRETIZAR_ELABORAR
  • [x] E_NO_COMECO
  • [x] VERBO_PARA_PRONOME_PESSOAL: moved to pt-pt
  • [x] TESE_PHD_PROCURAR_PROVAR_PROVARA
  • [x] QUE_SUBJ_VS_INF_PESS
  • [x] ORDINAL_ABREVIATION: moved to PT grammar
  • [x] LHE_S_ME_TE_VOS_VERB: moved to PT grammar
  • [x] GENTILICOS_LINGUAS: ongoing
  • [x] SIMPLIFICAR_VERBO_TER_MAIS_PARTICIPIO_PASSADO: ongoing
  • [x] VER_OBSERVAR_CONSTATAR: ongoing
  • [x] VERB_COMMA_CONJUNCTION: ongoing
  • [x] ABREVIATIONS_PUNCTUATION: ongoing
  • [x] QUE_VERBO: ongoing
  • [x] HIPHEN_SPACE_RULES: ongoing
  • [x] WORDINESS: ongoing
  • [x] ACHO_QUE: ongoing
  • [x] QUE_FORAM_FOI_SÃO_É_SENDO: ongoing
  • [x] DENTRO_DE_DA_DAS_DO_DOS_EM_NA_NAS_NO_NOS: ongoing
  • [x] FINAL_STOPS: ongoing
  • [x] **INTERROGATIVES_PUNTUATION: ongoing
  • [x] VERB_QUE_É_VERB_SER: ongoing
  • [x] IRREGULAR_PAST_PARTICIPLES: ongoing
  • [x] QUE_SER_ESTAR_PARTPASSADO: ongoing
  • [x] SEMICOLON_COLON_SPACING: ongoing
  • [x] REDUNDANT_CONJUNCTIONS: ongoing
  • [x] DECIMAL_COMMA: ongoing
  • [x] EU_NÓS_REMOVAL

Marco:

  • [ ] INFORMALITIES: PT-PT grammar
  • [x] GENERAL_GENDER_AGREEMENT_ERRORS
  • [ ] GENERAL_NUMBER_AGREEMENT_ERRORS

susanaboatto avatar Jul 15 '22 12:07 susanaboatto

The GENDER AGREEMENT will still take me weeks to fix as I have to rewrite all antipatterns and the same for the NUMBER AGREEMENT.

The rule that suggests adding a “!” after each interjection is very annoying, if you think it is useless, please delete it… every time one writes: “Olá, Marco.” it suggests adding a “!” to “Olá”.

marcoagpinto avatar Jul 15 '22 13:07 marcoagpinto

Some of these rules can be moved to pt-PT.

marcoagpinto avatar Jul 15 '22 13:07 marcoagpinto

But the “Olá!” should probably be deleted.

marcoagpinto avatar Jul 15 '22 13:07 marcoagpinto

@jaumeortola @susanaboatto @udomai @tiff @danielnaber @ricardojosehlima

I have been looking at the GENDER and NUMBER agreement rules.

They have not dozens, but probably hundreds of antipatterns.

I will have to test one by one, starting with the oldest antipatterns, since their results are probably replaced by newer antipatterns.

Since I am testing against 600 000 sentences, it will take months and not weeks, but it will eventually get done.

Not much I can do to speed up the task… I really have to test antipattern by antipattern.

What I can do is to alternate between GENDER and NUMBER to try to “kill” globally (reach more users in a general way).

marcoagpinto avatar Jul 15 '22 19:07 marcoagpinto

Hi @marcoagpinto a while ago I moved the rule INFORMALITIES to the PT-PT grammar. The numbers still don't look so good. Would you mind taking a look at it? If there's nothing to be done there, we should probably deactivate it.

susanaboatto avatar Aug 15 '22 10:08 susanaboatto

@susanaboatto

Sure, turn it "default=off", I will have a look at it in a few days.

Thanks!

marcoagpinto avatar Aug 15 '22 10:08 marcoagpinto

Right now, I am fixing the antipatterns of NUMBER AGREEMENT.

And I want to create two new rules before the INFORMALITIES.

❤️

marcoagpinto avatar Aug 15 '22 10:08 marcoagpinto

Awesome, many thanks! I have set INFORMALITIES off. Are your new rules for the pt-pt grammar or would they also include pt-br?

susanaboatto avatar Aug 15 '22 12:08 susanaboatto

@susanaboatto

The two rules are for BR + PT, but I will only be able to code them with the help of @ricardojosehlima .

He must be busy right now, since he didn't reply to one of them.

The other one the idea is still in text, and I will ask for his opinion first.

marcoagpinto avatar Aug 15 '22 12:08 marcoagpinto

@marcoagpinto Where did you ask him? Maybe I can help?

susanaboatto avatar Aug 15 '22 12:08 susanaboatto

@susanaboatto

https://github.com/languagetool-org/languagetool/issues/6966

Basically, what I really need is a good rule ID, rule name, and suggestion message.

Then I will need help to see which verbs can be used with the results… it will probably return a lot of results (I hope 😄 ), then we need to look at them to see the verbs it can be used with.

Thanks!

marcoagpinto avatar Aug 15 '22 12:08 marcoagpinto

@susanaboatto

I have solved the INFORMALITIES being disabled by users: https://github.com/languagetool-org/languagetool/commit/745886d39715c889a724acf20518e8a5c2e52193

Now I will slowly add valid words to the new entity.

marcoagpinto avatar Aug 16 '22 18:08 marcoagpinto