dify
dify copied to clipboard
Feat/add-remote-file-upload-api
Checklist:
[!IMPORTANT]
Please review the checklist below before submitting your pull request.
- [x] Please open an issue before creating a PR or link to an existing issue #9878
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I ran
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods
Description
-
File Upload Refactoring:
- Refactored file upload logic in multiple controllers to use a new
FileService.upload_filemethod signature. - The new method takes separate parameters for filename, content, mimetype, user, and source instead of a FileStorage object.
- Added checks for empty filenames and improved error handling.
- Refactored file upload logic in multiple controllers to use a new
-
Remote File Handling:
- Implemented a
RemoteFileUploadApiclass for handling remote file operations. - Added functionality to download remote files, guess MIME types and generate filenames when needed.
- Implemented a
-
Error Handling:
- Introduced a new
FilenameNotExistsErrorfor cases where a file is uploaded without a filename.
- Introduced a new
-
Controller Restructuring:
- Moved file-related controllers from
web/__init__.pyto separateweb/files.pyandweb/remote_files.pyfiles. - Updated imports and API resource registrations accordingly.
- Moved file-related controllers from
-
Setup Required Decorator:
- Moved the
setup_requireddecorator fromsetup.pytowraps.py. - Updated all imports of
setup_requiredto use the new location.
- Moved the
Fixes
Type of Change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update, included: Dify Document
- [ ] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
- [ ] Dependency upgrade
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
- [ ] Test A
- [ ] Test B