dify icon indicating copy to clipboard operation
dify copied to clipboard

Feat/add-remote-file-upload-api

Open laipz8200 opened this issue 1 year ago • 0 comments

Checklist:

[!IMPORTANT]
Please review the checklist below before submitting your pull request.

  • [x] Please open an issue before creating a PR or link to an existing issue #9878
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

  1. File Upload Refactoring:

    • Refactored file upload logic in multiple controllers to use a new FileService.upload_file method signature.
    • The new method takes separate parameters for filename, content, mimetype, user, and source instead of a FileStorage object.
    • Added checks for empty filenames and improved error handling.
  2. Remote File Handling:

    • Implemented a RemoteFileUploadApi class for handling remote file operations.
    • Added functionality to download remote files, guess MIME types and generate filenames when needed.
  3. Error Handling:

    • Introduced a new FilenameNotExistsError for cases where a file is uploaded without a filename.
  4. Controller Restructuring:

    • Moved file-related controllers from web/__init__.py to separate web/files.py and web/remote_files.py files.
    • Updated imports and API resource registrations accordingly.
  5. Setup Required Decorator:

    • Moved the setup_required decorator from setup.py to wraps.py.
    • Updated all imports of setup_required to use the new location.

Fixes

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update, included: Dify Document
  • [ ] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • [ ] Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Test A
  • [ ] Test B

laipz8200 avatar Oct 26 '24 16:10 laipz8200