dify icon indicating copy to clipboard operation
dify copied to clipboard
Published 5 days ago • verified publisher icon langgenius

feat: add analyticdb as model provider

Open lpdink opened this issue 1 year ago • 5 comments

Checklist:

[!IMPORTANT]
Please review the checklist below before submitting your pull request.

  • [x] Please open an issue before creating a PR or link to an existing issue
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

This pull request introduces support for AnalyticDB as a new model provider. Currently, AnalyticDB offers two reranking models, with plans to introduce embedding models in the future. This addition will allow customers who have purchased AnalyticDB instances to easily call these models.

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update, included: Dify Document
  • [ ] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • [ ] Dependency upgrade

Testing Instructions

The changes were tested using manually filled credentials.

lpdink avatar Oct 11 '24 05:10 lpdink

Please fix the lint and resolve the deps

crazywoola avatar Oct 12 '24 10:10 crazywoola

@crazywoola Thanks, I've fixed the linting issue and the changes have passed CI.

lpdink avatar Oct 12 '24 10:10 lpdink

@crazywoola The conflicts have been resolved. Could you please review and approve this PR?

lpdink avatar Oct 17 '24 08:10 lpdink

Hello, it seems to have conflicts again :( sorry for this. And you need to add tests for new providers.

crazywoola avatar Oct 22 '24 13:10 crazywoola

@crazywoola Sorry for missing the test, it's been added now and conflicts have been resolved.

lpdink avatar Oct 23 '24 06:10 lpdink

@crazywoola Conflicts have been resolved again.I noticed that it hasn't been reviewed in a while. Could you please take a look when you have a moment? Thank you!

lpdink avatar Nov 18 '24 08:11 lpdink

Please be aware that we are going to roll out the v1.0.0 changes related to models runtimes and tools will not take effect above v1.0, please make sure adapt the changes to https://github.com/langgenius/dify-official-plugins as well. :)

crazywoola avatar Feb 10 '25 11:02 crazywoola