dify icon indicating copy to clipboard operation
dify copied to clipboard

Feat:Add Pinecone as a new vector database

Open Howe829 opened this issue 1 year ago • 8 comments

Checklist:

[!IMPORTANT]
Please review the checklist below before submitting your pull request.

  • [x] Please open an issue before creating a PR or link to an existing issue
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

How to use: PS:You need to get the <PINECONE_API_KEY> and create a pinecone Index from the pinecone console.

First, add <PINECONE_API_KEY>, <PINECONE_INDEX>, <PINECONE_INDEX_DIMENSION> to your .env file. Second, change the <VECTOR_STORE> to 'pinecone'.

Fixes #8892

Type of Change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update, included: Dify Document
  • [ ] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • [ ] Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Test A
  • [ ] Test B

Howe829 avatar Sep 30 '24 09:09 Howe829

See comments

Hi! I'm glad to see your comment, I've resolved it.PTAL.

Howe829 avatar Oct 08 '24 02:10 Howe829

@Howe829 Hello, please resolve deps issue here.

crazywoola avatar Oct 09 '24 06:10 crazywoola

@Howe829 Hello, please resolve deps issue here.

Hi there! I've resolved the deps issues.The Pytest failed due to the api key provided in test_pinecone.py is not real.

Howe829 avatar Oct 09 '24 10:10 Howe829

@Howe829 Hello, please resolve deps issue here.

Hi there! I've resolved the deps issues.The Pytest failed due to the api key provided in test_pinecone.py is not real.

I think you need to mock api with calling pinecone to run pytest successfully.

yaoice avatar Oct 10 '24 02:10 yaoice

@Howe829 Hello, please resolve deps issue here.

Hi there! I've resolved the deps issues.The Pytest failed due to the api key provided in test_pinecone.py is not real.

I think you need to mock api with calling pinecone to run pytest successfully.

Thanks for your advice, all checks have passed.

Howe829 avatar Oct 10 '24 03:10 Howe829

Seems there more conflicts here.

crazywoola avatar Oct 14 '24 13:10 crazywoola

Seems there more conflicts here.

Resolved.PTAL @crazywoola

Howe829 avatar Oct 15 '24 01:10 Howe829

@Howe829 Hello there are some errors in the tests.

crazywoola avatar Oct 21 '24 01:10 crazywoola