dify icon indicating copy to clipboard operation
dify copied to clipboard

Fix : Workflow "start" paste url not support s3 pre-signed URL

Open ybalbert001 opened this issue 1 year ago • 3 comments

Checklist:

[!IMPORTANT]
Please review the checklist below before submitting your pull request.

  • [x] Please open an issue before creating a PR or link to an existing issue
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes https://github.com/langgenius/dify/issues/6718

Type of Change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update, included: Dify Document
  • [ ] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • [ ] Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] Test A
  • [x] Test B

ybalbert001 avatar Aug 01 '24 00:08 ybalbert001

I had already run "poetry lock" to update poetry.lock file and also submitted. Why this Pytest still throw error?

ybalbert001 avatar Aug 01 '24 04:08 ybalbert001

We have a sync-poetry and update-poetry scripts under dev/, have a try.

laipz8200 avatar Aug 02 '24 04:08 laipz8200

We have a sync-poetry and update-poetry scripts under dev/, have a try.

Fixed

ybalbert001 avatar Aug 02 '24 10:08 ybalbert001

Great!

laipz8200 avatar Aug 11 '24 08:08 laipz8200