dify icon indicating copy to clipboard operation
dify copied to clipboard

chore: merge lint-staged script

Open TinsFox opened this issue 9 months ago • 3 comments

Description

Merge lint-staged script

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • [x] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement

Suggested Checklist:

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] My changes generate no new warnings
  • [x] I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

TinsFox avatar May 15 '24 03:05 TinsFox

The title and the description emphasize the key change is merging eslints options, while prettier linter action is introduced for the js scripts as well. Is it the main purpose and what's impact of the PR ? If prettier is introduced for lining, how does it aligned to the automated style checks?

bowenliang123 avatar May 19 '24 13:05 bowenliang123

The title and the description emphasize the key change is merging eslints options, while prettier linter action is introduced for the js scripts as well. Is it the main purpose and what's impact of the PR ? If prettier is introduced for lining, how does it aligned to the automated style checks?

Sorry, I forgot to remove the prettier script before submitting.

TinsFox avatar May 20 '24 01:05 TinsFox

The title and the description emphasize the key change is merging eslints options, while prettier linter action is introduced for the js scripts as well. Is it the main purpose and what's impact of the PR ? If prettier is introduced for lining, how does it aligned to the automated style checks?

Sorry, I forgot to remove the prettier script before submitting.

Thanks for the reply. Let's know when the changes are ready.

bowenliang123 avatar May 20 '24 01:05 bowenliang123

This PR includes additional file submissions, so I'm closing it for now. Please resubmit later.

takatost avatar Jun 03 '24 19:06 takatost