dify icon indicating copy to clipboard operation
dify copied to clipboard

feat: Add google storage support

Open miendinh opened this issue 2 months ago • 1 comments

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update, included: Dify Document
  • [ ] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • [ ] Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] TODO

Suggested Checklist:

  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] My changes generate no new warnings
  • [ ] I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • [ ] optional I have made corresponding changes to the documentation
  • [ ] optional I have added tests that prove my fix is effective or that my feature works
  • [ ] optional New and existing unit tests pass locally with my changes

miendinh avatar Apr 26 '24 08:04 miendinh

The support for storage is increasing, we will consider splitting storage into factory methods in the future. 🥲

takatost avatar Apr 26 '24 11:04 takatost

The support for storage is increasing, we will consider splitting storage into factory methods in the future. 🥲

Vector Database Support, I think it should also be refactored to use factory methods. @takatost

miendinh avatar Apr 27 '24 05:04 miendinh