dify icon indicating copy to clipboard operation
dify copied to clipboard

add pgvecto_rs support and upgrade SQLAlchemy

Open JohnJyong opened this issue 1 year ago • 3 comments

Description

  1. support pgvecto_rs vector database
  2. upgrade SQLAlchemy to version 2.0.29

Type of Change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update, included: Dify Document
  • [ ] Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • [ ] Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] TODO

Suggested Checklist:

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] My changes generate no new warnings
  • [x] I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • [ ] optional I have made corresponding changes to the documentation
  • [ ] optional I have added tests that prove my fix is effective or that my feature works
  • [ ] optional New and existing unit tests pass locally with my changes

JohnJyong avatar Apr 25 '24 08:04 JohnJyong

It's great to embrace SQLAlchemy 2.x !

bowenliang123 avatar Apr 25 '24 14:04 bowenliang123

Are there any planned integration tests with pbvedto_rs vdb?

bowenliang123 avatar Apr 26 '24 08:04 bowenliang123

It would be better to split the pull request (PR) into two separate PRs. One for upgrading SQLAlchemy and another for adding support for pgvector_rs. This approach will make the process much simpler and clearer.

vaayne avatar Apr 27 '24 02:04 vaayne