dify icon indicating copy to clipboard operation
dify copied to clipboard

Update descriptions in StackExchange Tool

Open richards199999 opened this issue 3 months ago • 4 comments

Description

I update the tool StackExchange YAML in order to let it work functionally.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • [x] New feature (non-breaking change which adds functionality)
  • [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • [x] Tested on local machine. And the tool works pretty well.

Suggested Checklist:

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] My changes generate no new warnings

richards199999 avatar Mar 30 '24 01:03 richards199999

Thanks, but there are few things can be optimized.

  1. order, sort and pagesize should be changed to form type instead of llm, as for now, it's not stable enough, it gives much freedom to LLM which may lead a bad result.
  2. filter is a constant value, but it's declared in yaml and has a llm type and was marked as required, it means that the LLM must reasoning a filter parameter from the query of user, however, you know, it's not necessary.

Yeuoly avatar Mar 30 '24 10:03 Yeuoly

for the first point, actually, i use the form type before, but i found that when choosing form type, user need to first type in the wanted number, it is pretty annoying; and i have tested llm form, the model would always use correct number.😁

and for the second point, yes you are right. and i have change it.🫡🫡

richards199999 avatar Mar 31 '24 08:03 richards199999

for the first point, actually, i use the form type before, but i found that when choosing form type, user need to first type in the wanted number, it is pretty annoying; and i have tested llm form, the model would always use correct number.😁

and for the second point, yes you are right. but i'm not sure about how to do this.😢 i just need the value to be default as i intended to.

For the first one, you choose to use number or string as the type of your parameters and give a default value, such as pagesize: 5, sort: xxx, you can refer to bing.bing_search, what you want could be found there.

Yeuoly avatar Mar 31 '24 08:03 Yeuoly

Please fix the lint errors in ci builds.

crazywoola avatar Apr 01 '24 01:04 crazywoola

Sorry for that but could u pls rebase to main or merge main branch into your PR to fix the CI error, because there is a requirement update which results an error.

Yeuoly avatar Apr 01 '24 04:04 Yeuoly

@richards199999 There is a test needs to be fixed still. :)

crazywoola avatar Apr 03 '24 12:04 crazywoola

Hey there,

Thanks for letting me know about the test that still needs to be fixed. I apologize for the delay. I have some personal work to take care of these days, but I will make sure to get it done soon.

Thanks again for your understanding.

Richards

Sent via @.***>

On Wed, Apr 03, 2024 at 8:51 PM, crazywoola @.@.>> wrote:

@richards199999https://github.com/richards199999 There is a test needs to be fixed still. :)

— Reply to this email directly, view it on GitHubhttps://github.com/langgenius/dify/pull/3043#issuecomment-2034521049, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BB4QGP5SF63PKCTY76V2JTLY3P3MJAVCNFSM6AAAAABFPD66MGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZUGUZDCMBUHE. You are receiving this because you were mentioned.Message ID: @.***>

richards199999 avatar Apr 03 '24 16:04 richards199999

Sure! I have approved the change now🫡

richards199999 avatar Apr 06 '24 12:04 richards199999

Sure! I have approved the change now🫡

but have not modified yet?

Yeuoly avatar Apr 07 '24 02:04 Yeuoly

Sorry, what I mean is the type of the 2 fields should be select, not the descriptions.

Yeuoly avatar Apr 07 '24 06:04 Yeuoly

@Yeuoly hope this update would be correct.🤗 apologize for the late, i have some school works to do these days🙏

richards199999 avatar Apr 08 '24 07:04 richards199999