dify icon indicating copy to clipboard operation
dify copied to clipboard

feat: refact StepOne component and implement DataSourceSelector component with tests for file, Notion, and web sources

Open CodingOnStar opened this issue 2 weeks ago • 1 comments

Summary

feat: refact StepOne component and implement DataSourceSelector component with tests for file, Notion, and web sources

Checklist

  • [ ] This change requires a documentation update, included: Dify Document
  • [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • [x] I've updated the documentation accordingly.
  • [x] I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

CodingOnStar avatar Dec 24 '25 06:12 CodingOnStar

Summary of Changes

Hello @CodingOnStar, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the dataset creation StepOne component to enhance modularity, testability, and user experience. It introduces a new DataSourceSelector component for cleaner data source type selection and separates the implementation details for File, Notion, and Web sources into their own dedicated components. Additionally, a custom hook centralizes preview state management, and comprehensive tests have been added to validate the new architecture and components.

Highlights

  • Component Refactoring: The StepOne component has undergone significant refactoring, extracting its data source selection and content rendering logic into dedicated, modular sub-components for improved maintainability and readability.
  • New DataSourceSelector Component: A new DataSourceSelector component has been implemented to encapsulate the UI and logic for choosing between File, Notion, and Web data sources, enhancing the dataset creation workflow.
  • Modular Source Components: Dedicated components (FileSource, NotionSource, WebSource) have been introduced to handle the specific UI and logic for each data source type, replacing inline rendering within StepOne.
  • Centralized Preview State Management: A new usePreview custom hook has been added to centralize the state management for file, Notion page, and website previews, simplifying preview logic across different data sources.
  • Reusable UI Elements: New common components like NextStepButton and VectorSpaceAlert have been created to promote UI consistency and reusability within the dataset creation steps.
  • Comprehensive Testing: Extensive unit tests have been added for the new DataSourceSelector component, the refactored StepOne component, and each of the new source-specific components (FileSource, NotionSource, WebSource), ensuring robust functionality and preventing regressions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 24 '25 06:12 gemini-code-assist[bot]