dify icon indicating copy to clipboard operation
dify copied to clipboard

fix(workflow): tool plugin output_schema array type not selectable in subsequent nodes

Open importcjj opened this issue 1 month ago • 4 comments

…orkflow

Fixed an issue where array type fields (e.g., array[object]) defined in tool plugin output_schema could not be selected as input in subsequent workflow nodes.

The root cause was that the tool node's getOutputVars function was converting array types to string identifiers (e.g., "Array[object]") instead of proper VarType enums (e.g., VarType.arrayObject).

Changes:

  • Add output-schema-utils.ts with resolveVarType function to properly map JSON Schema types to VarType enums
  • Update default.ts to use the new resolveVarType function
  • Add comprehensive unit tests for the new utility functions

Fixes #28940 Fixes #27673

🤖 Generated with Claude Code

[!IMPORTANT]

  1. Make sure you have read our contribution guidelines
  2. Ensure there is an associated issue and you have been assigned to it
  3. Use the correct syntax to link this PR: Fixes #<issue number>.

Summary

Screenshots

Before After
... ...

Checklist

  • [ ] This change requires a documentation update, included: Dify Document
  • [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • [x] I've updated the documentation accordingly.
  • [x] I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

importcjj avatar Dec 02 '25 11:12 importcjj

Summary of Changes

Hello @importcjj, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug preventing array type outputs from tool plugins from being correctly recognized and selected as inputs in subsequent workflow nodes. The fix involves refactoring the type resolution logic within the workflow system, introducing a dedicated utility to accurately interpret JSON Schema definitions and map them to the appropriate internal variable types. This ensures seamless data flow and improved usability for workflows involving complex tool outputs.

Highlights

  • Fix Workflow Node Input: Resolved an issue where array type fields (e.g., array[object]) from tool plugin output_schema could not be correctly selected as input in subsequent workflow nodes.
  • Root Cause Addressed: The problem stemmed from the getOutputVars function incorrectly converting array types to string identifiers instead of proper VarType enums.
  • New Type Resolution Utility: Introduced output-schema-utils.ts with resolveVarType to accurately map JSON Schema types to VarType enums, including handling complex array types and nullable types.
  • Integration and Testing: Updated default.ts to utilize the new resolveVarType function and added comprehensive unit tests for the new utility.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 02 '25 11:12 gemini-code-assist[bot]

Can anyone review it ? @iamjoel @zxhlyh

importcjj avatar Dec 10 '25 12:12 importcjj

Requesting this be merged as well as it has solved a very frustrating problem for me.

pcfreak30 avatar Dec 11 '25 07:12 pcfreak30

@crazywoola

importcjj avatar Dec 12 '25 16:12 importcjj