dify icon indicating copy to clipboard operation
dify copied to clipboard

refactor: migrate common service toward TanStack Query

Open lyzno1 opened this issue 3 months ago • 6 comments

Summary

  • remove SWR Fetcher typing from common service
  • expose promise-based helpers for auth/workspace/provider flows to align with TanStack Query usage
  • preserve request shapes and response generics to avoid behavior changes

lyzno1 avatar Dec 02 '25 04:12 lyzno1

Summary of Changes

Hello @lyzno1, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring of the common service layer, primarily by decoupling it from SWR's Fetcher type. The change involves updating function signatures to explicitly return Promises, thereby preparing the service for a smoother transition or integration with TanStack Query, all while maintaining the integrity of existing API interactions.

Highlights

  • SWR Fetcher Typing Removal: The Fetcher typing from the SWR library has been removed from the common service functions.
  • Promise-based Helpers: Existing helper functions for authentication, workspace, and provider flows have been updated to expose promise-based interfaces, aligning with TanStack Query's usage patterns.
  • Behavior Preservation: The underlying request shapes and response generics have been carefully preserved to ensure no behavioral changes occur as a result of this refactoring.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 02 '25 04:12 gemini-code-assist[bot]

/gemini review

lyzno1 avatar Dec 08 '25 04:12 lyzno1

/gemini review

lyzno1 avatar Dec 08 '25 04:12 lyzno1

/gemini review

lyzno1 avatar Dec 08 '25 10:12 lyzno1

/gemini review

lyzno1 avatar Dec 08 '25 11:12 lyzno1

/gemini review

lyzno1 avatar Dec 09 '25 04:12 lyzno1