fix: correct scoring in WeightRerankRunner for hybrid search
[!IMPORTANT]
- Make sure you have read our contribution guidelines
- Ensure there is an associated issue and you have been assigned to it
- Use the correct syntax to link this PR:
Fixes #<issue number>.
Summary
Fixes #28125
- Prevent text search scores from being mistakenly treated as vector search scores during deduplication, which caused inaccurate ranking
- Fix usage of document.vector for cosine similarity, as document does not have this field
Screenshots
| Before | After |
|---|---|
Checklist
- [ ] This change requires a documentation update, included: Dify Document
- [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
- [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
- [x] I've updated the documentation accordingly.
- [x] I ran
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods
Summary of Changes
Hello @myml, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a critical issue in the hybrid search mechanism where the scoring of results was flawed due to the misinterpretation of full-text search scores as vector scores. The changes introduce a more robust reranking logic within the WeightRerankRunner, ensuring that keyword and vector search components are appropriately weighted and combined, leading to more accurate and relevant search result rankings.
Highlights
- Hybrid Search Scoring Correction: Implemented a fix to prevent full-text search scores from being incorrectly treated as vector search scores during the deduplication process in hybrid search, which previously led to inaccurate ranking.
-
Reranking Logic Refinement: Refactored the
WeightRerankRunnerto correctly calculate and combine keyword and vector scores for documents, ensuring that the final score accurately reflects both search components. -
document.vectorUsage Removal: Addressed an issue wheredocument.vectorwas incorrectly accessed for cosine similarity calculation, as thedocumentobject does not possess this field. Vector scores are now expected to be pre-calculated or handled differently.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
Thanks for the PR, please resolve the lint errors :)