fix: add missing release when creating dataset trace
Hi, I love this project
Traces in custom experiments with langfuse datasets via langchain handlers have no release tag.
Noticed that there was missing version argument when creating a trace.
Adding missing argument resolves the issue with missing tag.
This fix is based on the v2.60.5 release tag because the function does not exist in main. Please advise if I should rebase onto a different branch or if you prefer to cherry-pick this change.
[!IMPORTANT] Adds missing
versionargument totrace()call inget_langchain_handler()to fix missing release tags in traces.
- Behavior:
- Adds missing
version=self.langfuse.releaseargument toself.langfuse.trace()call inget_langchain_handler()inlangfuse/client.py.- Fixes missing release tag in traces for custom experiments with Langfuse datasets via Langchain handlers.
- Context:
- Based on v2.60.5 release tag, not present in the main branch.
This description was created by
for 97933d2b66688b11048415175439d11c7853d5d6. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
Added missing version argument to trace() call in get_langchain_handler() method to ensure proper release tagging for dataset experiment traces via LangChain handlers.
- Added
version=self.langfuse.releaseparameter toself.langfuse.trace()call inlangfuse/client.pyto fix missing release tags - Change targets v2.60.5 since the function doesn't exist in main branch yet
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
Thanks again for your contribution @exekerey - this is supported now in our new Langfuse SDK v3 🙏🏾