langfuse-python icon indicating copy to clipboard operation
langfuse-python copied to clipboard

fix: add missing release when creating dataset trace

Open exekerey opened this issue 9 months ago • 1 comments

Hi, I love this project

Traces in custom experiments with langfuse datasets via langchain handlers have no release tag. Noticed that there was missing version argument when creating a trace. Adding missing argument resolves the issue with missing tag.

This fix is based on the v2.60.5 release tag because the function does not exist in main. Please advise if I should rebase onto a different branch or if you prefer to cherry-pick this change.


[!IMPORTANT] Adds missing version argument to trace() call in get_langchain_handler() to fix missing release tags in traces.

  • Behavior:
    • Adds missing version=self.langfuse.release argument to self.langfuse.trace() call in get_langchain_handler() in langfuse/client.py.
    • Fixes missing release tag in traces for custom experiments with Langfuse datasets via Langchain handlers.
  • Context:
    • Based on v2.60.5 release tag, not present in the main branch.

This description was created by Ellipsis for 97933d2b66688b11048415175439d11c7853d5d6. You can customize this summary. It will automatically update as commits are pushed.

Greptile Summary

Disclaimer: Experimental PR review

Added missing version argument to trace() call in get_langchain_handler() method to ensure proper release tagging for dataset experiment traces via LangChain handlers.

  • Added version=self.langfuse.release parameter to self.langfuse.trace() call in langfuse/client.py to fix missing release tags
  • Change targets v2.60.5 since the function doesn't exist in main branch yet

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

exekerey avatar May 25 '25 07:05 exekerey

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 25 '25 07:05 CLAassistant

Thanks again for your contribution @exekerey - this is supported now in our new Langfuse SDK v3 🙏🏾

hassiebp avatar Jul 15 '25 08:07 hassiebp