langflow icon indicating copy to clipboard operation
langflow copied to clipboard

fix: Add async aupdate_build_config to CustomComponent

Open cbornet opened this issue 1 year ago • 1 comments

Add async aupdate_build_config to CustomComponent. This also fixes blocking calls that where made through update_build_config by calling aupdate_build_config instead

cbornet avatar Dec 10 '24 13:12 cbornet

CodSpeed Performance Report

Merging #5181 will degrade performances by 26.93%

Comparing cbornet:async-update-build-config (ff614f7) with main (5ee995e)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 12 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main cbornet:async-update-build-config Change
test_get_and_cache_all_types_dict 1,958.4 µs 854.4 µs ×2.3
test_successful_run_with_input_type_text 248.8 ms 170.9 ms +45.59%
test_successful_run_with_output_type_any 245 ms 335.2 ms -26.93%

codspeed-hq[bot] avatar Dec 10 '24 13:12 codspeed-hq[bot]

We should have a test using ComponentTestBase to make sure this PR does not break backwards compatibility.

done.

cbornet avatar Dec 11 '24 15:12 cbornet