langflow icon indicating copy to clipboard operation
langflow copied to clipboard

fix: update Notify and Listen to inherit from Component

Open joaoguilhermeS opened this issue 1 year ago • 1 comments

This PR refactor the Notify and Listen Components, that were in the old format.

Closes #4322

joaoguilhermeS avatar Nov 05 '24 19:11 joaoguilhermeS

CodSpeed Performance Report

Merging #4413 will degrade performances by 10.95%

Comparing jg/refactor/notify-listen (3b6baa9) with main (76c91de)

Summary

⚡ 1 improvements ❌ 1 regressions ✅ 13 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main jg/refactor/notify-listen Change
test_invalid_run_with_input_type_chat 14.6 ms 16.4 ms -10.95%
test_successful_run_with_input_type_text 453 ms 335.3 ms +35.12%

codspeed-hq[bot] avatar Nov 05 '24 19:11 codspeed-hq[bot]