langflow icon indicating copy to clipboard operation
langflow copied to clipboard

Fix dockerfile

Open yantxs opened this issue 2 years ago • 5 comments

Facing error when building image.

image

Logspace repo on Docker Hub is not accessible.

yantxs avatar Mar 15 '23 02:03 yantxs

Yeah. I'll look into that now.

Those Dockerfiles were being used mainly for development but things changed a bit in the last few days.

Thanks for the heads up.

ogabrielluiz avatar Mar 15 '23 09:03 ogabrielluiz

With docker compose up in the root folder you should be able to run the development containers. Running it in the docker_example folder should run langflow with the latest version.

ogabrielluiz avatar Mar 19 '23 03:03 ogabrielluiz

I see this post docker-compose up: frontend_1 | sh: react-scripts: not found

EDIT: I see it is using dev.Dockerfile. If I run this in src/frontend before the root up, it works. npm i

vid avatar Mar 19 '23 11:03 vid

Hey. I made some changes on a feature branch to test this and I think I got it working.

Would you be willing to test it on your side too? The branch is called fix_frontend_dockerfile.

You should delete the node_modules folder to make sure you have a clean slate to test. This is an issue with npm binary and the commit I made fixes that I think.

If you run make install_frontend before running docker compose up you should be good to go too, though.

We might update the Makefile to make it easier in case this fix does not work.

ogabrielluiz avatar Mar 19 '23 14:03 ogabrielluiz

I'v added a dev command to the makefile which runs make install_frontend then builds and runs the containers. This should create a reliable way to run a dev environment.

ogabrielluiz avatar Mar 20 '23 00:03 ogabrielluiz

The containers are working pretty well now with the dev command. We can open a new issue if other bugs arise.

Thanks for the heads up, @yantxs!

ogabrielluiz avatar Mar 20 '23 21:03 ogabrielluiz