langchain4j-examples icon indicating copy to clipboard operation
langchain4j-examples copied to clipboard

Published 20 hours ago • verified publisher icon langchain4j

unify the coding style of using testcontainers

Open feuyeux opened this issue 1 year ago • 3 comments

To unify the coding style of using testcontainers, and improve maturity for logging

feuyeux avatar Feb 06 '24 09:02 feuyeux

Hey @feuyeux thanks a lot and sorry for the delay with review! I have noticed that there is also this PR which seems to overlap with yours. Could you please take a look?

langchain4j avatar Feb 23 '24 10:02 langchain4j

Hey @feuyeux thanks a lot and sorry for the delay with review! I have noticed that there is also this PR which seems to overlap with yours. Could you please take a look?

Thanks for reply, and I just checked #60 pull request，there're some files changed on both. What I did is let all series of vector dbs to use log instead of system out, for example, and both of use did unify the coding style on testcontainers.

So, I can merge this PR if it approved before mine, with pleasure. Or vice versa, maybe :)

feuyeux avatar Feb 24 '24 03:02 feuyeux

Hey @feuyeux thanks a lot and sorry for the delay with review! I have noticed that there is also this PR which seems to overlap with yours. Could you please take a look?

I found that https://github.com/langchain4j/langchain4j-examples/pull/60 had merged, and then I just merge with it, please review.

feuyeux avatar Mar 30 '24 04:03 feuyeux

@langchain4j Please take a quick look, there's no conflects

feuyeux avatar Apr 18 '24 03:04 feuyeux

I just created a new PR, and let's move to https://github.com/langchain4j/langchain4j-examples/pull/78.

feuyeux avatar Apr 23 '24 17:04 feuyeux