langsmith-sdk icon indicating copy to clipboard operation
langsmith-sdk copied to clipboard

Issue: can we mark `orjson` as optional? Because it's incompatible with `pypy`

Open CNSeniorious000 opened this issue 8 months ago • 1 comments

Issue you'd like to raise.

Looks like we only use orjson to speed up (de)serialization, so maybe it could be an optional-dependency, which is required in non-pypy environment?

Suggestion:

Setting a markers = "platform_python_implementation != 'PyPy'" in pyproject.toml and use another JSON parser to de(serialize) JSON (for example, pydantic-core's JSON parser or the std's one) if orjson is not installed.

CNSeniorious000 avatar Jun 18 '24 09:06 CNSeniorious000