langserve icon indicating copy to clipboard operation
langserve copied to clipboard

fix: correct the request URL construction in playground

Open jianzs opened this issue 1 year ago • 3 comments
trafficstars

Previously, the playground was building request URLs by removing the playground suffix and appending stream_log. This worked when the URL ended with playground, but failed for URLs ending with index.html. The issue was the code only checked for URLs ending with playground and did not account for index.html endings.

jianzs avatar Apr 26 '24 07:04 jianzs

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the username @jianzs on file. In order for us to review and merge your code, please complete the Individual Contributor License Agreement here https://forms.gle/AQFbtkWRoHXUgipM6 .

This process is done manually on our side, so after signing the form one of the maintainers will add you to the contributors list.

For more details about why we have a CLA and other contribution guidelines please see: https://github.com/langchain-ai/langserve/blob/main/CONTRIBUTING.md.

cla-bot[bot] avatar Apr 26 '24 07:04 cla-bot[bot]

@jianzs thank you, I'll review and release next week

eyurtsev avatar Apr 26 '24 21:04 eyurtsev

@eyurtsev Hi there! I was wondering if you might have some time to review the PR I submitted? Please feel free to point out any issues or concerns at your convenience.

jianzs avatar May 06 '24 02:05 jianzs