langgraph icon indicating copy to clipboard operation
langgraph copied to clipboard

Update Corrective RAG demo with small fixes

Open AndresHG opened this issue 1 year ago • 3 comments

I have been playing with Corrective RAG demo in LangGraph repository and gave found some small issues and typos. Here is the list of them:

  • OpenAI model GPT-4o-mini is cheaper and supports structured output as opposite to gpt-3.5-turbo used along the script
  • Added a small section to load dotenv and quick-setup for LangSmith
  • Some prints at the end of the script were broken or not showing the expected output
  • Typo: "ALL DOCUMENTS ARE NOT RELATED TO THE QUESTION..."; actually this is triggered if at least 1 of them is not relevant, so the message is wrong.

AndresHG avatar Jan 24 '25 14:01 AndresHG

Hello @eyurtsev , dotenv is something I added at the end, but not really relevant, just a helpful thing I considered, but I can quickly delete that. What about the other typos and warnings fixed? Running the notebook with GPT 3.5 will generate a warning or a braking error.

AndresHG avatar Jan 27 '25 22:01 AndresHG

Ah let me check -- I may have been fooled by GitHub rich display

eyurtsev avatar Jan 27 '25 23:01 eyurtsev

@eyurtsev is this still open? happy to add a review if so, but don't want to waste time if not.

hesreallyhim avatar May 13 '25 01:05 hesreallyhim

We're going to do a docs refactor here quite soon, going to close for now, but can ping you for feedback when we return to this resource. Thanks!

sydney-runkle avatar Jun 09 '25 16:06 sydney-runkle