langchain icon indicating copy to clipboard operation
langchain copied to clipboard

Minor update to reference other sql tool by tool names instead of hard coded string.

Open edwardzjl opened this issue 1 year ago • 3 comments

Currently there are 4 tools in SQL agent-toolkits, and 2 of them have reference to the other 2.

This PR change the reference from hard coded string to {tool.name}

edwardzjl avatar Jul 11 '23 05:07 edwardzjl

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jul 11, 2023 1:59pm

vercel[bot] avatar Jul 11 '23 05:07 vercel[bot]

Sorry I think I missed one, the QuerySQLCheckerTool also has a reference of QuerySQLDataBaseTool. Or do you think it's better to modify the reference in these tools' default description?

edwardzjl avatar Jul 11 '23 13:07 edwardzjl

Sorry I think I missed one, the QuerySQLCheckerTool also has a reference of QuerySQLDataBaseTool. Or do you think it's better to modify the reference in these tools' default description?

Done.

edwardzjl avatar Jul 11 '23 13:07 edwardzjl

awesome, thanks @edwardzjl!

baskaryan avatar Jul 11 '23 21:07 baskaryan