langchain icon indicating copy to clipboard operation
langchain copied to clipboard

Published 20 hours ago • verified publisher icon langchain-ai

docs(agents/agent_types): Fix code example in chat_conversation_agent.mdx

Open finnless opened this issue 2 years ago • 2 comments

Replace this comment with:

  • Description: Adds missing code to the example so it can be run. Copied from conversational agent example.
  • Issue: -
  • Dependencies: -
  • Tag maintainer: @baskaryan
  • Twitter handle: @finnless

finnless avatar Jul 09 '23 01:07 finnless

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jul 9, 2023 1:18am

vercel[bot] avatar Jul 09 '23 01:07 vercel[bot]

this code snippet is imported in a file with other snippets that already define these variables, so doesn't the end result doc not need this? https://python.langchain.com/docs/modules/agents/agent_types/chat_conversation_agent

baskaryan avatar Jul 09 '23 05:07 baskaryan

Fair enough, although it could be confusing if someone goes directly to that section https://python.langchain.com/docs/modules/agents/agent_types/chat_conversation_agent#using-a-chat-model

Also ConversationBufferMemory is repeated from the first notebook.

https://github.com/hwchase17/langchain/blob/2667ddc6867421842fe027f1946644f452de8eb3/docs/snippets/modules/agents/agent_types/chat_conversation_agent.mdx#L3-L8

I'll close for now.

finnless avatar Jul 12 '23 06:07 finnless