langchain icon indicating copy to clipboard operation
langchain copied to clipboard

feat: Add support for the Solidity language

Open 0xJord4n opened this issue 1 year ago • 5 comments

Add Solidity programming language support for code splitter.

Twitter: @0xjord4n_

Who can review?

Tag maintainers/contributors who might be interested: @hwchase17

0xJord4n avatar Jun 12 '23 17:06 0xJord4n

Thanks for the contribution!

(1) Can you please add a short notebook with example usage in docs/modules/indexes/text_splitters/examples/. (2) Also, run make format (if you are set up w/ Poetry here)*.

*I can do this for you if you are not set up for run formatting.

No problem sir, I'll do that rn

0xJord4n avatar Jun 13 '23 16:06 0xJord4n

Also, minor nit: do you mind rebasing on master? We merged another text splitter recently.

rlancemartin avatar Jun 13 '23 16:06 rlancemartin

Also, please run make format to resolve lint errors.

LMK if you don't have poetry, etc set up and I can run for you.

rlancemartin avatar Jun 13 '23 18:06 rlancemartin

Also, please run make format to resolve lint errors.

LMK if you don't have poetry, etc set up and I can run for you.

Yes sir, I'm doing the poetry etc setup

0xJord4n avatar Jun 13 '23 18:06 0xJord4n

@rlancemartin I have finished

0xJord4n avatar Jun 13 '23 19:06 0xJord4n

Thanks!

rlancemartin avatar Jun 14 '23 21:06 rlancemartin