langchain icon indicating copy to clipboard operation
langchain copied to clipboard

Make embedding object optional for ElasticKnnSearch

Open jeffvestal opened this issue 1 year ago • 0 comments

Feature request

Make embedding an optional arg when creating ElasticKnnSearch class

Motivation

If a user is only going to run knn/hybrid search AND use the query_vector_builder having an embedding object is not needed as ES will generate the embedding during search

Your contribution

I will make the changes

jeffvestal avatar Jun 02 '23 19:06 jeffvestal