langchain icon indicating copy to clipboard operation
langchain copied to clipboard

Published 20 hours ago • verified publisher icon langchain-ai

Fix AimCallbackHandler on_chain_* methods

Open mcleonard opened this issue 1 year ago • 2 comments

Fix AimCallbackHandler on_chain_* methods

The AimCallbackHandler methods on_chain_start and on_chain_end fail due to a change in dictionary keys. This PR updates the keys.

Who can review?

Tracing / Callbacks

  • @agola11

mcleonard avatar May 10 '23 20:05 mcleonard

just pinged the AIM team for help with reviewing!

hwchase17 avatar May 18 '23 04:05 hwchase17

Hey @hwchase17 can you please assign me as a reviewer?

tamohannes avatar May 18 '23 17:05 tamohannes

@mcleonard I think the aim.Run call is obsolete on the __init__ method (line 169). The setup method is meant to initialize the aim run. So I recommend calling the setup at the end of the __init__, or in any other method that you believe will be called the first at the beginning of the processes, e.g. on_llm/chain_start.

tamohannes avatar May 18 '23 18:05 tamohannes

stale

baskaryan avatar Aug 11 '23 21:08 baskaryan