langchain
langchain copied to clipboard
langchain-ai
OneDriveLoader
Hi @hwchase17 ! First of all, thanks for this great project. This is my first contribution, and I'm trying to dive deep into the details. This loader relies on O-365 package. Should I keep this as an optional dependency or include it in the pyproject.toml ?
Hi @hwchase17 ! First of all, thanks for this great project. This is my first contribution, and I'm trying to dive deep into the details. This loader relies on O-365 package. Should I keep this as an optional dependency or include it in the
pyproject.toml?
this is great! lets include as an optional dependency in the pyproject.toml file. that will mean both putting something like python-o365 = {version = "...", optional =True} as well as adding it to the list of packages in the extra_installs all section
i am happy to do these changes (along with others i point out in the pr) if you want - just let me know! it can be a bit tedious/confusing, but happy to let you slog through it if you want (you said you wanted to dive deep on the details). but, im very happy to do it for this pr so you can see the usual pr - let me know!
Hi @hwchase17 ! First of all, thanks for this great project. This is my first contribution, and I'm trying to dive deep into the details. This loader relies on O-365 package. Should I keep this as an optional dependency or include it in the
pyproject.toml?this is great! lets include as an optional dependency in the pyproject.toml file. that will mean both putting something like
python-o365 = {version = "...", optional =True}as well as adding it to the list of packages in the extra_installsallsectioni am happy to do these changes (along with others i point out in the pr) if you want - just let me know! it can be a bit tedious/confusing, but happy to let you slog through it if you want (you said you wanted to dive deep on the details). but, im very happy to do it for this pr so you can see the usual pr - let me know!
Done!