langchain icon indicating copy to clipboard operation
langchain copied to clipboard

Surface AgentExecutor kwargs for toolkits

Open zachschillaci27 opened this issue 1 year ago • 1 comments

Surface separate kwargs for Agent and AgentExecutor in a consistent way for the agent toolkits. Following the example in create_pbi_agent and create_pbi_chat_agent,agent_kwargs and kwargs are now accessible for all AgentExecutor creator functions. This allows the user to separately control the Agent and AgentExecutor parameters.

NOTE: This will modify the behavior for some of the existing toolkits.

zachschillaci27 avatar Apr 27 '23 07:04 zachschillaci27

since (as you noted) this changes behavoir for a good amount of toolkits, id actually prefer to keep kwargs to agent, and add agent_executor_kwargs as a dictionary (and update the pbi toolkit, since that would just be one toolkit changed, rather than the 6 here

Good point, I had considered doing the same originally. Let me change it

zachschillaci27 avatar Apr 29 '23 10:04 zachschillaci27

lgtm, i can help squash merge conflicts

thanks!

zachschillaci27 avatar May 02 '23 06:05 zachschillaci27