langchain icon indicating copy to clipboard operation
langchain copied to clipboard

Published 20 hours ago • verified publisher icon langchain-ai

unit test / code coverage improvements

Open HunterGerlach opened this issue 2 years ago • 1 comments

This PR has two contributions:

  1. Add test for when stop token is found in middle of text

  2. Add code coverage tooling and instructions

  • Add pytest-cov via poetry
  • Add necessary config files
  • Add new make instruction for coverage
  • Update README with coverage guidance
  • Update minor README formatting/spelling

HunterGerlach avatar Dec 12 '22 08:12 HunterGerlach

@hwchase17 Merge conflicts resolved and poetry update made, Still looks like the automated build is failing for some reason/

HunterGerlach avatar Dec 12 '22 16:12 HunterGerlach

I'm not a poetry expert, but I suspect it has something to do with my version of poetry building lock files in v2 format, while the original is still in v1.

HunterGerlach avatar Dec 13 '22 04:12 HunterGerlach

Yup - that was it :tada:

Created a separate PR to specifically address the version bump...

https://github.com/hwchase17/langchain/pull/328

HunterGerlach avatar Dec 13 '22 04:12 HunterGerlach

Yup - that was it 🎉

Created a separate PR to specifically address the version bump...

#328

got it - thanks for debugging! will just merge this one. locally i was on poetry version 1.2.2 (which has forward compatability with v2 format) so this wont actually affect me (and other people on that version)

Thanks for doing this!

hwchase17 avatar Dec 13 '22 13:12 hwchase17