langchain icon indicating copy to clipboard operation
langchain copied to clipboard

[community] [Bugfix] base_o365 document loader metadata needs to be JSON serializable

Open MacanPN opened this issue 1 year ago • 1 comments

In order for indexer to work, all metadata in the documents need to be JSON serializable. Timestamps are not.

See here: https://github.com/MacanPN/langchain/blob/6a44b97bca6d4adafbbdedf42b51aef14f5780cd/libs/core/langchain_core/indexing/api.py#L91

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

MacanPN avatar Sep 11 '24 14:09 MacanPN

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 0:27am

vercel[bot] avatar Sep 11 '24 14:09 vercel[bot]

@baskaryan , @efriis, @eyurtsev, @ccurme, @vbarda, @hwchase17 is anyone interested in picking up this tiny bugifx? Indxing documents from O365 loader does not work without it. Thanks!

MacanPN avatar Oct 02 '24 12:10 MacanPN

Pretty pretty please @baskaryan , @efriis, @eyurtsev, @ccurme, @vbarda, @hwchase17 :-)

MacanPN avatar Oct 08 '24 07:10 MacanPN

Hey! Here's a link to the review policy: https://python.langchain.com/docs/contributing/review_process/

Status is currently needs support

efriis avatar Oct 09 '24 06:10 efriis

Would love to see this fixed. It's small and a relatively obvious bug.

petergoldstein avatar Oct 09 '24 14:10 petergoldstein

This would be a great fix

avalon-swain avatar Oct 09 '24 19:10 avalon-swain

@efriis Could you please let me know what else can I do? There's 6 upvotes on the PR now, it's literally 2 lines of code (10 characters) and it keeps O365 loader from being index-able by Langchain Indexing.

MacanPN avatar Oct 11 '24 07:10 MacanPN